[PATCH] D96193: [ELF] Rewriting the path of sample profile file for --reproduce response.txt

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 6 21:48:21 PST 2021


MaskRay added inline comments.


================
Comment at: lld/test/ELF/reproduce-lto.s:13
 # RUN: tar tvf repro1.tar | FileCheck %s --implicit-check-not={{.}}
+# RUN: tar xvf repro1.tar &> %t2
+# RUN: cat repro1/response.txt >> %t2
----------------
hoy wrote:
> MaskRay wrote:
> > I don't think the output of tar is portable.
> > 
> > `FileCheck %s --check-prefix=RSP < repro1/response.txt`
> I'd like to check the path in response.txt matches the path in the tar ball, or at least it is a relative path. Not sure what is a good way. Maybe I can limit the test to Linux only.
Perhaps `xvf` is fine...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96193/new/

https://reviews.llvm.org/D96193



More information about the llvm-commits mailing list