[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

It is a good move. I see that in old pass manager, the initialization phases of all passes run before the body of any pass starts, so for many passes, they will see different names for the same symbol in initialization phase and main phase. SampleProfileLoaderPass is affected for example. It is less of a problem for new pass manager. However, the requirement of putting UniqueInternalLinkageNamesPass very early in the pipeline is still a very strong requirement. It is possible for other pass to have the same requirement and to cause conflict. So like to see the refactoring and thanks for the improvement!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96109/new/

https://reviews.llvm.org/D96109