[PATCH] D96109: Refactor implementation of -funique-internal-linkage-names.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 13:04:53 PST 2021


dblaikie added a comment.

(might be simpler to add the new functionality to Clang, having Clang opt out of the old functionality (to avoid both unique prefixes being added together, I guess?) and then separately remove the LLVM functionality in a follow-up patch, once it's unused by Clang.



================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:202
+    // numbers or characters but not both.
+    llvm::APInt IntHash = llvm::APInt(128, Str.str(), 16);
+    // Prepend "__uniq" before the hash for tools like profilers to understand
----------------
Can remove some syntax here:


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96109/new/

https://reviews.llvm.org/D96109



More information about the llvm-commits mailing list