[PATCH] D96117: [AMDGPU][MC] Corrected error position for invalid dim modifiers
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 5 07:32:00 PST 2021
foad added a comment.
Looks OK, but it's a shame to have to repeat the same error message three times in the source.
================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:7193
+ if (getLoc() != Loc) {
+ Error(StartLoc, "Invalid dim value");
return MatchOperand_ParseFail;
----------------
All the other errors start with a lower case letter.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96117/new/
https://reviews.llvm.org/D96117
More information about the llvm-commits
mailing list