[PATCH] D96122: [GlobalISel] Start using vectors in GISelKnownBits

[Jay Foad via Phabricator via llvm-commits]

foad added reviewers: dsanders, aditya_nandakumar.
foad added a comment.

"we consider bit as knows if it same for all" -> "we consider a bit as known if it is the same for all"

Looks pretty good to me, but adding some more globalisel folks in case they have comments.



================
Comment at: llvm/lib/CodeGen/GlobalISel/GISelKnownBits.cpp:171
+
+      computeKnownBitsImpl(MI.getOperand(i + 1).getReg(), Known2, DemandedElts,
+                           Depth + 1);
----------------
Don't pass in DemandedElts here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96122/new/

https://reviews.llvm.org/D96122