[PATCH] D95966: [AIX][support] Implement getHostCPUName

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1237
+  switch (_system_configuration.implementation) {
+  case PowerCPUImpl::POWER4:
+    return "pwr4";
----------------
stevewan wrote:
> Might be a dumb question, but why do we need the enum and can't do 
> 
> ```
>   switch (_system_configuration.implementation) {
>   case POWER_4:
>   ...
> ```
The original thinking was to benefit from `-Wswitch-enum` if someone missed something, but to be honest it just likely we'd miss it there, so I think we can just simply this as suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95966/new/

https://reviews.llvm.org/D95966