[PATCH] D95966: [AIX][support] Implement getHostCPUName

Steven Wan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 12:00:42 PST 2021


stevewan added inline comments.


================
Comment at: llvm/lib/Support/Host.cpp:1232
+  POWER9 = POWER_9,
+  POWER10 = 0x40000
+};
----------------
I suspect we're going to update this once `POWER_10` is defined by the system header, do we need a TO-DO before that happens?


================
Comment at: llvm/lib/Support/Host.cpp:1237
+  switch (_system_configuration.implementation) {
+  case PowerCPUImpl::POWER4:
+    return "pwr4";
----------------
Might be a dumb question, but why do we need the enum and can't do 

```
  switch (_system_configuration.implementation) {
  case POWER_4:
  ...
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95966/new/

https://reviews.llvm.org/D95966



More information about the llvm-commits mailing list