[PATCH] D95953: yaml2obj: Handle NT_* string values in for ELF note types

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 01:27:04 PST 2021


arichardson added inline comments.


================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:76
+#define ECase(X) IO.enumCase(Value, #X, ELF::X)
+  // Generic note types
+  ECase(NT_VERSION);
----------------
jhenderson wrote:
> Nit: here and most comments below, add a trailing full stop.
I coped those from ELF.h, will add full stops there too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95953/new/

https://reviews.llvm.org/D95953



More information about the llvm-commits mailing list