[PATCH] D95953: yaml2obj: Handle NT_* string values in for ELF note types

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 00:33:54 PST 2021


jhenderson added a comment.

Could you write a yaml2obj test that uses one or two of those NT values (as well as showing that the hex version works too), please? There's probably already a test that uses hex values for notes, so that would be the one to expand.



================
Comment at: llvm/lib/ObjectYAML/ELFYAML.cpp:76
+#define ECase(X) IO.enumCase(Value, #X, ELF::X)
+  // Generic note types
+  ECase(NT_VERSION);
----------------
Nit: here and most comments below, add a trailing full stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95953/new/

https://reviews.llvm.org/D95953



More information about the llvm-commits mailing list