[PATCH] D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes

[Ed Maste via Phabricator via llvm-commits]

emaste added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-freebsd.test:94
+#  FreeBSD       0x00000004      NT_FREEBSD_FEATURE_CTL
+#   Features: ASLR_DISABLE PROTMAX_DISABLE STKGAP_DISABLE WXNEEDED unknown (0xfffffff0)
+#  FreeBSD       0x00000001      NT_FREEBSD_FEATURE_CTL
----------------
`0xfffffff0` looks like an ELF Tool Chain bug :(


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6614-6615
+      }
+      // No pretty-printing available, fall back to printing the raw data.
+      // TODO: we should probably do this for the other notes too?
+    }
----------------
yes, should fall back to raw data if no pretty printer available; GNU and ELF Tool Chain readelf do this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74393/new/

https://reviews.llvm.org/D74393