[PATCH] D74393: [llvm-readobj] Add support for decoding FreeBSD ELF notes

Wed Feb 3 07:23:23 PST 2021

arichardson added inline comments.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-freebsd-core.test:34
+      - Name:            FreeBSD
+        Desc:            '4c6f72656d20697073756d20646f6c6f722073697420616d65740a00'
+        Type:            0x00000003
----------------
jhenderson wrote:
> Is this just arbitrary data? If so, can you make it look more arbitrary by reducing the size and maybe make it some sort of pattern like "aabbccdd00"? If not, please add a comment showing what this should represent.
Yes that makes sense, I just copied the value from the .s file.

================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-freebsd-core.test:35
+        Desc:            '4c6f72656d20697073756d20646f6c6f722073697420616d65740a00'
+        Type:            0x00000003
+ProgramHeaders:
----------------
jhenderson wrote:
> Is Type 3 one of the non-core ones, or just undefined? Please add a comment explaining why "3".
Again this is a copy from the .s file, and it is a valid type.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74393/new/

https://reviews.llvm.org/D74393