[PATCH] D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization

Tue Feb 2 21:24:07 PST 2021

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

In D95916#2538304 <https://reviews.llvm.org/D95916#2538304>, @MaskRay wrote:

>> Couldn't that be done with an assembly file with multiple .file directives? (as much as possible, it'd be good to keep test coverage in the project where the code is - with the cross-project lit testing area more for end-to-end/extra integration (though targeted/narrowly scoped) coverage)
>
> In GNU as, the placement of `.file` appears to affect its symbol table position. However, MC ELFObjectWriter places STT_FILE before all other symbols.

Sounds like that might be worth fixing for correctness and testability.

================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/symtab-notype.s:49
+l_notype:
+  retq
+.size l_notype, . - l_notype
----------------
retq that could be a nop so as not to draw undue attention/questions (could cause a reader to wonder if there's some importance to this difference - if there is no important difference, it'd be more readable if it weren't different)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95916/new/

https://reviews.llvm.org/D95916