[PATCH] D95916: DebugInfo/Symbolize: Allow STT_NOTYPE/STT_GNU_IFUNC symbols for .symtab symbolization

Tue Feb 2 20:41:28 PST 2021

MaskRay added a comment.

> Couldn't that be done with an assembly file with multiple .file directives? (as much as possible, it'd be good to keep test coverage in the project where the code is - with the cross-project lit testing area more for end-to-end/extra integration (though targeted/narrowly scoped) coverage)

In GNU as, the placement of `.file` appears to affect its symbol table position. However, MC ELFObjectWriter places STT_FILE before all other symbols.

================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/symtab-notype.s:13-14
+# CHECK-EMPTY:
+# CHECK-NEXT:  ??:0:0
+# CHECK-NEXT:  ??:0:0
+# CHECK-EMPTY:
----------------
dblaikie wrote:
> what are these two lines of output from? (if the gap is covered by the checks on 18 and 19?
(I forgot to write `| FileCheck...`)

================
Comment at: llvm/test/DebugInfo/Symbolize/ELF/symtab-notype.s:26-34
+# CHECK-NEXT:  l_notype_nosize
+# CHECK-NEXT:  ??:0:0
+# CHECK-EMPTY:
+# CHECK-NEXT:  l_notype_nosize
+# CHECK-NEXT:  ??:0:0
+# CHECK-EMPTY:
+# CHECK-NEXT:  l_notype_nosize
----------------
dblaikie wrote:
> Is this consistent with gnu addr2line behavior? Seems slightly weird to symbolize addresses outside the size of the section, I'd have thought?
Added a TODO.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95916/new/

https://reviews.llvm.org/D95916