[PATCH] D95832: [SampleFDO][NFC] Add inline keywords to member functions that will be in the template header file

[David Li via Phabricator via llvm-commits]

davidxl added a comment.

Good to know that SampleCoverageTracker can remain as it is (not templatized).  Is it possible to not move it into the header?  There are a few advantages:

1. reduce the size of the patch and merge churns;
2. a little better in compile time as the functions don't need to be built when building FlowSensitiveSampleLoader.

There are a few ways -- only move the class body to the header (so that inline keyword is not needed) or introduce some wrapper/helper function (taking tracker reference)  with forward declaration of TrackerType.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95832/new/

https://reviews.llvm.org/D95832