[PATCH] D95832: [SampleFDO][NFC] Add inline keywords to member functions that will be in the template header file

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

> I meant the functions move the header file. In the header file, we can achieve the same by adding an inline keyword to the out of class function definition (vs in class definition). Out of class definitions have better readability because some of the functions are really large.

Have you considered to define SampleProfileImpl.cc in addition to SampleProfileImpl.h so some large function can be put in .cc file and don't need inline keyword? But they need explicit instantiation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95832/new/

https://reviews.llvm.org/D95832