[PATCH] D95391: AMDGPU: Add support for amdgpu-unsafe-fp-atomics attribute
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 2 15:18:10 PST 2021
rampitec added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:11759
if (AS == AMDGPUAS::GLOBAL_ADDRESS && Subtarget->hasAtomicFaddInsts()) {
- if (!fpModeMatchesGlobalFPAtomicMode(RMW))
+ if (UnsafeFpAtomics != "true" && !fpModeMatchesGlobalFPAtomicMode(RMW))
return AtomicExpansionKind::CmpXChg;
----------------
I believe condition should be "or", not "and". Expand if either is not satisfied.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95391/new/
https://reviews.llvm.org/D95391
More information about the llvm-commits
mailing list