[PATCH] D95391: AMDGPU: Add support for amdgpu-unsafe-fp-atomics attribute

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 15:13:31 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:11754-11756
+    bool UnsafeFpAtomics =
+        RMW->getFunction()->getFnAttribute("amdgpu-unsafe-fp-atomics")
+            .getValueAsString() == "true";
----------------
arsenm wrote:
> Should sink this down to be the final check
The idea was to hide the string attribute lookup as the final check. as in 

!fpModeMatchesGlobalFPAtomicMode(RMW) && attributeStuff()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95391/new/

https://reviews.llvm.org/D95391



More information about the llvm-commits mailing list