[PATCH] D95832: [SampleFDO][NFC] Add inline keywords to member functions that will be in the template header file

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 13:41:31 PST 2021


davidxl added a comment.

Ok.

question: it seems SampleCoverageTracker implementation is independent of IR/MIR level. Do we need to templatize it ?

For SampleProfileLoader class, is there any part of of the code that is independent of the IR level which can be extracted into a base class (to avoid pulling a lot of definitions into header)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95832/new/

https://reviews.llvm.org/D95832



More information about the llvm-commits mailing list