[PATCH] D95832: [SampleFDO][NFC] Add inline keywords to member functions that will be in the template header file

[Rong Xu via llvm-commits]

I meant the functions move the header file. In the header file, we can
achieve the same by adding an inline keyword to the out of class function
definition (vs in class definition). Out of class definitions have better
readability because some of the functions are really large.

On Tue, Feb 2, 2021 at 12:40 PM David Li via Phabricator <
reviews at reviews.llvm.org> wrote:

> davidxl added a comment.
>
> Is the intention to move them (inline bodies) into the header? For those
> functions that are not, leave them as being defined out of line. Otherwise
> moving them into class body is a preparation for the next step (moving to
> header).
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D95832/new/
>
> https://reviews.llvm.org/D95832
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210202/27cb9f09/attachment.html>