[PATCH] D95561: [Clang] Introduce Swift async calling convention.

[John McCall via Phabricator via llvm-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8106-8115
+  case ParsedAttr::AT_SwiftAsyncCall:
   case ParsedAttr::AT_VectorCall:
   case ParsedAttr::AT_MSABI:
   case ParsedAttr::AT_SysVABI:
   case ParsedAttr::AT_Pcs:
   case ParsedAttr::AT_IntelOclBicc:
   case ParsedAttr::AT_PreserveMost:
----------------
varungandhi-apple wrote:
> There seems to be some weirdness here in `handleCallConvAttr` where the codepath to attach the attribute to the decl isn't taken. Instead in my examples, it exits out at this line:
> 
> ```
>   if (hasDeclarator(D)) return;
> ```
> 
> with an `isa<DeclaratorDecl>` check.
It doesn't need to be attached to the decl; it should be reflected in the type, the same as the other calling conventions.  You would need it on the decl for something like an ObjC method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95561/new/

https://reviews.llvm.org/D95561