[PATCH] D95561: [Clang] Introduce Swift async calling convention.

Varun Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 2 12:29:07 PST 2021


varungandhi-apple added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:2711
+      Out << 'T';
+      break;
     case CC_PreserveMost: Out << 'U'; break;
----------------
rjmccall wrote:
> Please use consistent formatting with the other cases, here and elsewhere.  Keeping the switch compact is better for readability than following an abstract style rule.
I'm pretty sure I wrote it the right way originally, but saying yes to the clang-tidy prompt by `arc` broke it. :sigh:


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95561/new/

https://reviews.llvm.org/D95561



More information about the llvm-commits mailing list