[PATCH] D95878: [AMDGPU]: Fixes an invalid clamp selection pattern.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp:92-107
   const auto Cmp1 = MatchInfo.Cmp1;
   const auto Cmp2 = MatchInfo.Cmp2;
   const auto Diff = std::abs(Cmp2 - Cmp1);
 
   // If the difference between both comparison values is 0 or 1, there is no
   // need to clamp.
   if (Diff == 0 || Diff == 1)
----------------
Can you extract this into a separate function and call it in the passing cases instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95878/new/

https://reviews.llvm.org/D95878