[PATCH] D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/docs/HowToUpdateDebugInfo.rst:352
+
+The ``debugify`` utility pass can operate in a different mode, when it checks
+the preservation of the original/real Debug Info metadata in optimizations.
----------------
aprantl wrote:
> How about: `In addition to automatically generating debug info, the checks provided by the ``debugify`` utility pass can also be used to test the preservation of pre-existing debug info metadata.`
Looks good to me. :)


================
Comment at: llvm/test/DebugInfo/debugify-original-dbginfo.ll:5
+
+; CHECK: CheckModuleDebugify (original debuginfo): PASS
+
----------------
aprantl wrote:
> This test has the same fundamental problem: It may fail on a different target, when instcombine is updated, ...
> Can you do the same unittest trick here? (perhaps with an idempotent transformation?)
Sure.

>This test has the same fundamental problem: It may fail on a different target, when instcombine is updated, ...
just curious -- I thought that all targets should handle Debug Info on the IR level the same way, but obviously that is not true?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82545/new/

https://reviews.llvm.org/D82545