[PATCH] D82545: [Debugify] Make the debugify aware of the original (-g) Debug Info

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/docs/HowToUpdateDebugInfo.rst:352
+
+The ``debugify`` utility pass can operate in a different mode, when it checks
+the preservation of the original/real Debug Info metadata in optimizations.
----------------
How about: `In addition to automatically generating debug info, the checks provided by the ``debugify`` utility pass can also be used to test the preservation of pre-existing debug info metadata.`


================
Comment at: llvm/test/DebugInfo/debugify-original-dbginfo.ll:5
+
+; CHECK: CheckModuleDebugify (original debuginfo): PASS
+
----------------
This test has the same fundamental problem: It may fail on a different target, when instcombine is updated, ...
Can you do the same unittest trick here? (perhaps with an idempotent transformation?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82545/new/

https://reviews.llvm.org/D82545