[PATCH] D95700: [AMDGPU] Be more specific in needsFrameBaseReg

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 14:45:13 PST 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp:416-417
 
   if (SIInstrInfo::isMUBUF(*MI))
     return !SIInstrInfo::isLegalMUBUFImmOffset(FullOffset);
 
----------------
arsenm wrote:
> Move this up and then just exit on isFLATScratch
I would need to call getScratchInstrOffset() twice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95700/new/

https://reviews.llvm.org/D95700



More information about the llvm-commits mailing list