[PATCH] D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:214
+    Flags:        [ SHF_ALLOC, SHF_EXECINSTR ]
+    Address:      0x10000000
+    AddressAlign: 0x1000
----------------
pattop wrote:
> MaskRay wrote:
> > I'll use a smaller address. If something goes off, this would not create a 260MB output.
> Do you want me to update the patch with this changed, or are you happy to adjust it when committing?
Please update it.

I am happy with the patch, just wanted to give others some time reviewing it as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95569/new/

https://reviews.llvm.org/D95569