[PATCH] D95569: [llvm-objcopy] -O binary: consider SHT_NOBITS sections to be empty

Patrick Oppenlander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 31 14:23:03 PST 2021


pattop added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/binary-paddr.test:214
+    Flags:        [ SHF_ALLOC, SHF_EXECINSTR ]
+    Address:      0x10000000
+    AddressAlign: 0x1000
----------------
MaskRay wrote:
> I'll use a smaller address. If something goes off, this would not create a 260MB output.
Do you want me to update the patch with this changed, or are you happy to adjust it when committing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95569/new/

https://reviews.llvm.org/D95569



More information about the llvm-commits mailing list