[PATCH] D95747: Fix modules build for LLVMOrcShared

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added a comment.

@lhames Does anything prevent us from having a dedicated JITTargetAddress in OrcShared? Am I remembering correctly, that JITSymbol is last dependency to ExecutionEngine? Maybe, now that release 12 branched we could think about planning a change like this?



================
Comment at: llvm/include/llvm/module.modulemap:196
   exclude header "ExecutionEngine/Orc/RPC/RPCSerialization.h"
   exclude header "ExecutionEngine/Orc/RPC/RawByteChannel.h"
 
----------------
These moved to OrcShared, but I don't get errors as is. So, can we just remove them?


================
Comment at: llvm/include/llvm/module.modulemap:212
 // be removed in the future.
 module LLVM_OrcSupport {
   requires cplusplus
----------------
Is OrcSupport meant as the lib we call OrcShared today?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95747/new/

https://reviews.llvm.org/D95747