[PATCH] D95747: Fix modules build for LLVMOrcShared
Stefan Gränitz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 30 12:24:54 PST 2021
sgraenitz created this revision.
sgraenitz added reviewers: teemperor, lhames.
Herald added subscribers: hiraditya, mgorny.
sgraenitz requested review of this revision.
Herald added a project: LLVM.
Follow-up from D92873 <https://reviews.llvm.org/D92873>. OrcShared shouldn't depend on intrinsics_gen, it should only include code that is required in both, OrcJIT and OrcTargetProcess. The former already depends on intrinsics_gen and the latter doesn't need it.
This is a minimal change for fixing the modules build while avoiding the OrcShared dependency to intrinsics_gen -- not necessarily final. I think there are two discussion topics here:
(1) Should we clean up the module map? It seems there are some outdated entries.
(2) Can we copy/move a subset of ExecutionEngine's JITSymbol.h to OrcShared as proposed here and/or improve it?
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D95747
Files:
llvm/include/llvm/ExecutionEngine/Orc/Shared/JITSymbol.h
llvm/include/llvm/ExecutionEngine/Orc/Shared/TargetProcessControlTypes.h
llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/OrcRPCTPCServer.h
llvm/include/llvm/module.modulemap
llvm/lib/ExecutionEngine/Orc/Shared/CMakeLists.txt
llvm/lib/ExecutionEngine/Orc/TargetProcess/RegisterEHFrames.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95747.320321.patch
Type: text/x-patch
Size: 5281 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210130/265d44aa/attachment.bin>
More information about the llvm-commits
mailing list