[PATCH] D95580: [mlir][spirv] Add support for OpImageType

[Lei Zhang via Phabricator via llvm-commits]

antiagainst requested changes to this revision.
antiagainst added a comment.
This revision now requires changes to proceed.

Awesome, just one final nit from me.



================
Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp:1023
+  auto dim = spirv::symbolizeDim(operands[2]);
+  if (!dim)
+    return emitError(unknownLoc, "missing Dim for OpTypeImage") << operands[2];
----------------
It isn't missing. It's "unknown Dim for OpTypeImage: "

Similarly for others. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95580/new/

https://reviews.llvm.org/D95580