[PATCH] D95580: [mlir][spirv] Add support for OpImageType

[Weiwei via Phabricator via llvm-commits]

Weiwei-2021 added inline comments.


================
Comment at: mlir/test/Target/SPIRV/image.mlir:3
+
+spv.module Logical GLSL450 requires #spv.vce<v1.0, [Shader], []> {
+  // CHECK: !spv.ptr<!spv.image<f32, Dim1D, NoDepth, NonArrayed, SingleSampled, NoSampler, Unknown>, UniformConstant>
----------------
Weiwei-2021 wrote:
> antiagainst wrote:
> > I feel we don't need all these combinations: if one enumerant works, others in the same enum will work too. So a few cases to vary as much as possible would be good enough. :)
> Only keep three combinations here. Notice that the var number is unordered. I will fixed it later. 
> Only keep three combinations here. Notice that the var number is unordered. I will fixed it later. 

fix the numbering now. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95580/new/

https://reviews.llvm.org/D95580