[PATCH] D94487: [LTO] Use lto::backend for code generation.

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 11:04:14 PST 2021


dexonsmith added inline comments.


================
Comment at: llvm/include/llvm/LTO/LTO.h:198
+  }
+  NativeObjectStream(raw_pwrite_stream *OS) : OS(OS) {}
+  /// NativeObjectStream may own the allocation of the used raw_pwrite_stream,
----------------
As a drive-by comment: if this sticks around, please make construct this from a reference to prevent raw owned pointers from coming in this way (if we need a constructor from `nullptr` the unique_ptr constructor will still work). (That said, I agree with Steven that changing the test tool would be better.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94487/new/

https://reviews.llvm.org/D94487



More information about the llvm-commits mailing list