[PATCH] D94487: [LTO] Use lto::backend for code generation.

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

LGTM with only one comment.



================
Comment at: llvm/include/llvm/LTO/LTO.h:202
+  std::unique_ptr<raw_pwrite_stream> OS_;
+  raw_pwrite_stream *OS;
   virtual ~NativeObjectStream() = default;
----------------
I guess this only exists to support `bool compileOptimized(ArrayRef<raw_pwrite_stream *> Out)`?

That seems to only an interface used in `llvm-lto` which is a test tool. I wonder if we can just change the interface so we don't need to worry about if NativeObjectStream owning the output stream or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94487/new/

https://reviews.llvm.org/D94487