[PATCH] D95681: [GlobalISel] Fix modifying a G_OR without notifying the observer

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:5502
+  unsigned Flags = MI.getFlags();
+  MIRBuilder.buildInstr(TargetOpcode::G_OR, {Dst}, {And0, And1}, Flags);
 
----------------
foad wrote:
> arsenm wrote:
> > There should be a buildOr
> There is a buildOr but it doesn't take Flags because it's very unusual to set fast math flags on a bitwise operation.
It should probaly just have the flags operand


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95681/new/

https://reviews.llvm.org/D95681