[PATCH] D95681: [GlobalISel] Fix modifying a G_OR without notifying the observer
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 29 07:39:07 PST 2021
foad added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:5502
+ unsigned Flags = MI.getFlags();
+ MIRBuilder.buildInstr(TargetOpcode::G_OR, {Dst}, {And0, And1}, Flags);
----------------
arsenm wrote:
> There should be a buildOr
There is a buildOr but it doesn't take Flags because it's very unusual to set fast math flags on a bitwise operation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95681/new/
https://reviews.llvm.org/D95681
More information about the llvm-commits
mailing list