[PATCH] D95675: [AMDGPU][MC] Corrected parsing of optional modifiers

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 06:11:05 PST 2021


foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5933
+    StringRef Tok = getTokenStr();
+    if (Tok.startswith(Pref) && Tok.substr(Pref.size()) == Id) {
+      lex();
----------------
drop_front might be a bit clearer than substr?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95675/new/

https://reviews.llvm.org/D95675



More information about the llvm-commits mailing list