[PATCH] D95675: [AMDGPU][MC] Corrected parsing of optional modifiers

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 05:16:50 PST 2021


dp created this revision.
dp added reviewers: rampitec, foad.
Herald added subscribers: kerbowa, jfb, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl, arsenm.
dp requested review of this revision.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Summary of changes:

- Refactored parseNamedBit;
- Removed obsoleted code (handling of default values have changed long ago);
- Fixed bugs in parsing of "no*" modifiers (bug 41282 <https://bugs.llvm.org/show_bug.cgi?id=41282>);
- Improved errors handling.


https://reviews.llvm.org/D95675

Files:
  llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  llvm/test/MC/AMDGPU/flat-global.s
  llvm/test/MC/AMDGPU/flat-scratch-instructions.s
  llvm/test/MC/AMDGPU/gfx8_err_pos.s
  llvm/test/MC/AMDGPU/gfx9_err_pos.s
  llvm/test/MC/AMDGPU/vop3-modifiers-err.s
  llvm/test/MC/AMDGPU/vop3-modifiers.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95675.320106.patch
Type: text/x-patch
Size: 16227 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210129/88f4d09e/attachment.bin>


More information about the llvm-commits mailing list