[PATCH] D95667: [NFC][RISCV] Remove redundant pseudo instructions for vector load/store.

Zakk Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 29 00:17:03 PST 2021


khchen accepted this revision.
khchen added a comment.
This revision is now accepted and ready to land.

Yes, thanks for fixup!
LGTM.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3165
 // Pseudos Unit-Stride Loads and Stores
-foreach eew = EEWList in {
-  defm PseudoVLE # eew : VPseudoUSLoad;
-  defm PseudoVSE # eew : VPseudoUSStore;
-}
+defm PseudoVL : VPseudoUSLoad</*fault-only-first*/false>;
+defm PseudoVS : VPseudoUSStore;
----------------
`/*fault-only-first=*/` is correct style.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td:3192
 let hasSideEffects = 1, Defs = [VL] in
-foreach eew = EEWList in {
-  defm PseudoVLE # eew # FF : VPseudoUSLoad;
-}
+defm PseudoVL : VPseudoUSLoad</*fault-only-first*/true>;
 
----------------
Ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95667/new/

https://reviews.llvm.org/D95667



More information about the llvm-commits mailing list