[PATCH] D95630: [flang][fir] Remove references to code to be removed.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Lower/CharacterExpr.cpp:358
   builder.setInsertionPointToStart(iterWhile.getBody());
   auto index = iterWhile.getInductionVar();
   // Look for first non-blank from the right of the character.
----------------
schweitz wrote:
> mehdi_amini wrote:
> > I'm confused, isn't this code gonna crash now? `iterWhile` was referring to an op created but not you just have a null value.
> This is a prelude to D95399. They are mutually dependent patches.
> 
> (1) Don't want to expand the size of D95399.
> (2) Want to make D95399 a buildable chunk on its own.
> 
OK, but it is hard to make sense of a patch like this one which makes the code fundamentally wrong.
Also this patch does not even build right now according to the premerge testing:
```
/mnt/disks/ssd0/agent/llvm-project/flang/lib/Lower/ConvertType.cpp:167:12: error: no member named 'ComplexType' in namespace 'fir'; did you mean 'mlir::ComplexType'?
    return fir::ComplexType::get(context, KIND);
           ^~~~~~~~~~~~~~~~
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95630/new/

https://reviews.llvm.org/D95630