[PATCH] D95630: [flang][fir] Remove references to code to be removed.

Eric Schweitz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 10:11:39 PST 2021


schweitz added inline comments.


================
Comment at: flang/lib/Lower/CharacterExpr.cpp:358
   builder.setInsertionPointToStart(iterWhile.getBody());
   auto index = iterWhile.getInductionVar();
   // Look for first non-blank from the right of the character.
----------------
mehdi_amini wrote:
> I'm confused, isn't this code gonna crash now? `iterWhile` was referring to an op created but not you just have a null value.
This is a prelude to D95399. They are mutually dependent patches.

(1) Don't want to expand the size of D95399.
(2) Want to make D95399 a buildable chunk on its own.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95630/new/

https://reviews.llvm.org/D95630



More information about the llvm-commits mailing list