[PATCH] D95400: [flang][fir] Upstream FIR support changes

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: flang/lib/Optimizer/Support/FIRContext.cpp:24
+  mod->setAttr(tripleName, fir::OpaqueAttr::get(mod.getContext(), &triple));
+}
+
----------------
The triple seems fairly fundamental to processing a Module, it isn't clear to me that this can be an OpaqueAttr (i.e. something that should be implicitly dropped freely with no consequence). How do you manage this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95400/new/

https://reviews.llvm.org/D95400