[PATCH] D95400: [flang][fir] Upstream FIR support changes

[Eric Schweitz via Phabricator via llvm-commits]

schweitz added inline comments.


================
Comment at: flang/include/flang/Optimizer/Support/FIRContext.h:12
+//===----------------------------------------------------------------------===//
+/// \file
+///
----------------
kiranchandramohan wrote:
> Is this stray or a directive to some tool?
It's a doxygen directive. Not sure it is needed though.


================
Comment at: flang/include/flang/Optimizer/Support/InternalNames.h:44
+    VARIABLE,
+    BLOCK_DATA_NAME
   };
----------------
kiranchandramohan wrote:
> Nit: Was this previously in alphabetical order?
Good catch. Thanks.


================
Comment at: flang/lib/Optimizer/Support/InternalNames.cpp:102
 
+std::string fir::NameUniquer::doBlockData(llvm::StringRef name) {
+  std::string result = prefix();
----------------
kiranchandramohan wrote:
> Did we have tests for all these?
No. I don't think we do.


================
Comment at: flang/lib/Optimizer/Support/KindMapping.cpp:310
+KindTy fir::KindMapping::defaultDoubleKind() const {
+  auto iter = defaultMap.find('c');
+  assert(iter != defaultMap.end());
----------------
kiranchandramohan wrote:
> Should this be 'd'?
Another good catch. Thanks again.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95400/new/

https://reviews.llvm.org/D95400