[PATCH] D95580: [mlir][spirv] Add support for OpImageType

[Weiwei via Phabricator via llvm-commits]

Weiwei-2021 added inline comments.


================
Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp:1012
+  // TODO: Add support for Access Qualifier.
+  assert(!operands.empty() && "No operands for processing image type");
+  if (operands.size() != 8)
----------------
ergawy wrote:
> small nit: I think the following `if` condition is more appropriate for this check. We can remove this line.
> 
> (Hope you don't mind me passing by :) ).
:) Thank you for reviewing!  I will remove this assertion and upload again (after I figure out how to upload a revision. This is my first time using this system - still learning. :p)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95580/new/

https://reviews.llvm.org/D95580