[PATCH] D95580: [mlir][spirv] Add support for OpImageType

[Kareem Ergawy via Phabricator via llvm-commits]

ergawy added inline comments.


================
Comment at: mlir/lib/Target/SPIRV/Deserialization/Deserializer.cpp:1012
+  // TODO: Add support for Access Qualifier.
+  assert(!operands.empty() && "No operands for processing image type");
+  if (operands.size() != 8)
----------------
small nit: I think the following `if` condition is more appropriate for this check. We can remove this line.

(Hope you don't mind me passing by :) ).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95580/new/

https://reviews.llvm.org/D95580