[PATCH] D95489: [AMDGPU] Do not reassign spilled registers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 26 19:37:05 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNRegBankReassign.cpp:482
+  if (Def && ((Def->isCopy() && Def->getOperand(1).getReg() == PhysReg) ||
+              TII->isSpill(*Def)))
     return false;
----------------
rampitec wrote:
> arsenm wrote:
> > Can you tell if it's a spill from the VirtRegMap instead?
> I don't see how.
Does Register::isStackSlot return true here, or does VRM->getStackSlot() != NO_STACK_SLOT tell you?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95489/new/

https://reviews.llvm.org/D95489



More information about the llvm-commits mailing list