[PATCH] D95449: [flang] Fix problems with constant arrays with lower bounds that are not 1

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld added inline comments.


================
Comment at: flang/lib/Evaluate/check-expression.cpp:312
+      : lbounds_{std::move(lbounds)} {
+    CHECK(lbounds);
+  }
----------------
tskeith wrote:
> Since `lbounds` has to be a non-empty optional, why make it optional at all? I.e. why not declare it as `ConstantSubscripts &&lbounds`?
Thanks, Tim.  Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95449/new/

https://reviews.llvm.org/D95449