[PATCH] D95449: [flang] Fix problems with constant arrays with lower bounds that are not 1
Tim Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 27 15:42:51 PST 2021
tskeith added inline comments.
================
Comment at: flang/lib/Evaluate/check-expression.cpp:312
+ : lbounds_{std::move(lbounds)} {
+ CHECK(lbounds);
+ }
----------------
Since `lbounds` has to be a non-empty optional, why make it optional at all? I.e. why not declare it as `ConstantSubscripts &&lbounds`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95449/new/
https://reviews.llvm.org/D95449
More information about the llvm-commits
mailing list