[PATCH] D95136: [X86] Fix tile config register spill issue.

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 28 05:03:16 PST 2021


LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:235
+    bool NeedUpdatePred = true;
+    bool HasCallBeforeAMX = false;
+    SuccStatus MaxSucc = NoAMXAtAll;
----------------
pengfei wrote:
> LuoYuanke wrote:
> > xiangzhangllvm wrote:
> > > Can use a better name for HasCallBeforeAMX? it is very easy to mix with HasAfterCallAMX when I read here
> > Agree. It is easy to mix with HasBeforeCallAMX.
> Should `IsCallBeforeAMX` better?
Maybe HasCallBeforeAMXInBB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95136/new/

https://reviews.llvm.org/D95136



More information about the llvm-commits mailing list