[PATCH] D95136: [X86] Fix tile config register spill issue.

[Pengfei Wang via Phabricator via llvm-commits]

pengfei marked an inline comment as done.
pengfei added inline comments.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:229
+
+struct ReloadTileConfig {
+  enum SuccStatus { NoAMXAtAll = 0, HasAfterCallAMX, HasBeforeCallAMX };
----------------
xiangzhangllvm wrote:
> LGTM for the logic.
Thanks for the review.


================
Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:235
+    bool NeedUpdatePred = true;
+    bool HasCallBeforeAMX = false;
+    SuccStatus MaxSucc = NoAMXAtAll;
----------------
LuoYuanke wrote:
> xiangzhangllvm wrote:
> > Can use a better name for HasCallBeforeAMX? it is very easy to mix with HasAfterCallAMX when I read here
> Agree. It is easy to mix with HasBeforeCallAMX.
Should `IsCallBeforeAMX` better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95136/new/

https://reviews.llvm.org/D95136