[PATCH] D95158: Use DataExtractor to decode SLEB128 in android_relas.

Thu Jan 28 01:29:25 PST 2021

rahmanl added a comment.

In D95158#2524766 <https://reviews.llvm.org/D95158#2524766>, @jhenderson wrote:

> In D95158#2524564 <https://reviews.llvm.org/D95158#2524564>, @rahmanl wrote:
>
>> @jhenderson Is this ready to land?
>
> Sorry, I got caught up with things yesterday and didn't get to all the review requests I had to field.
>
> I guess the test case I'm thinking of is showing that the malformed group reloc count value means we don't get the "relocation group unexpectedly large" error. I don't feel strongly enough about this though to push for more testing if you don't want to add it.

Thanks for the response. I see your point now. But the "relocation group unexpectedly large" error has been tested by asm5.s in the same test file above. So I think we should be good to land.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95158/new/

https://reviews.llvm.org/D95158